Gpu support brineco2pvt #4319
Open
Gpu support brineco2pvt #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atgeirr
reviewed
Jan 2, 2025
| int activityModel = 3, | ||
| int thermalMixingModelSalt = 1, | ||
| int thermalMixingModelLiquid = 2, | ||
| Scalar T_ref = 288.71, //(273.15 + 15.56) | ||
| Scalar P_ref = 101325); | ||
|
|
||
| explicit BrineCo2Pvt(ContainerT brineReferenceDensity, |
There was a problem hiding this comment.
This is not a 1-argument constructor, remove explicit.
(Unlike the one above which can be called with a single argument, although I do not like it. We should consider removing the defaults. In fact, some of those arguments are useless since we require the exact T_ref and P_ref above! It is also suspect to take integer arguments that are easily mixed, when we already have enum classes for two of them and should make one for activityModel.)
Should the ContainerT in this constructor argument list be const references?
| namespace Opm::gpuistl { | ||
| template<class Scalar, class Params, class GPUContainer> | ||
| BrineCo2Pvt<Scalar, Params, GPUContainer> | ||
| move_to_gpu(BrineCo2Pvt<Scalar> cpuBrineCo2) { |
There was a problem hiding this comment.
Should be const ref? Prefer brace on new line for functions and classes, also for make_view().
multitalentloes
force-pushed
the
gpu_support_brineco2pvt
branch
2 times, most recently
from
85541a2 to
68ebd79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add necessary make_view and move_to_gpu functions to have brineCo2Pvt on the gpu